fix: add reaction display to inline review comments on diff tab#346
Open
AbhiVarde wants to merge 2 commits intobetter-auth:mainfrom
Open
fix: add reaction display to inline review comments on diff tab#346AbhiVarde wants to merge 2 commits intobetter-auth:mainfrom
AbhiVarde wants to merge 2 commits intobetter-auth:mainfrom
Conversation
|
@AbhiVarde is attempting to deploy a commit to the better-auth Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #345
Also fixes #347
Reactions were working on the Conversation tab but not on the Code (diff) tab.
The Code tab renders inline review comments inside
SingleFileDiff→InlineCommentDisplayinpr-diff-viewer.tsx, but had no reaction UI wired up.Changes in
apps/web/src/components/pr/pr-diff-viewer.tsx:ReactionDisplayandReactionstype from@/components/shared/reaction-displayreactionsfield to theReviewCommentinterface<ReactionDisplay>below each inline comment body, usingcontentType="pullRequestReviewComment"Changes in
apps/web/src/components/shared/reaction-display.tsx:getUsersForReactionto prevent duplicate avatars and React key warningsScreenshots
Before
After